Skip to content

Add vTPM to VMware provisioning #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lennonka merged 6 commits into from
Feb 4, 2025
Merged

Add vTPM to VMware provisioning #3602

Lennonka merged 6 commits into from
Feb 4, 2025

Conversation

@Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Jan 21, 2025 •
edited
Loading

What changes are you introducing?

Adding Virtual Trusted Platform Module compute-profile option and user permissions to VMware provisioning

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Documents theforeman/foreman#10324

SAT-30464 (public)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into: probably none

  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@github-actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

The PR preview for 94f42d1 is available at theforeman-foreman-documentation-preview-pr-3602.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@Lennonka Lennonka marked this pull request as draft January 21, 2025 12:23
@Lennonka Lennonka force-pushed the add-secureboot-vmware branch from fea7cc7 to efe6933 Compare January 22, 2025 17:40
@Lennonka Lennonka changed the title Add Secure Boot to VMware provisioning Add vTPM to VMware provisioning Jan 22, 2025
@Lennonka Lennonka force-pushed the add-secureboot-vmware branch from efe6933 to e493afd Compare January 22, 2025 17:45
@Lennonka Lennonka marked this pull request as ready for review January 22, 2025 17:45
@Lennonka Lennonka added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Jan 24, 2025
nofaralfasi
nofaralfasi reviewed Jan 28, 2025
View reviewed changes
@Lennonka Lennonka force-pushed the add-secureboot-vmware branch from 397d43b to 99135b5 Compare January 28, 2025 11:54
@Lennonka
Copy link
Contributor Author

Lennonka commented Jan 28, 2025

@nofaralfasi @Gauravtalreja1 Ack?

@Lennonka Lennonka added tech review done No issues from the technical perspective testing done No issues from the functional perspective and removed Needs tech review Requires a review from the technical perspective labels Jan 30, 2025
maximiliankolb
maximiliankolb reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, rest LGTM. I did not test this completely.

@Lennonka @maximiliankolb
Fix capitalization
94f42d1 
Co-authored-by: Maximilian Kolb <[email protected]>
@Lennonka Lennonka added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Feb 4, 2025
@Lennonka Lennonka merged commit bfc6930 into theforeman:master Feb 4, 2025
9 checks passed
@Lennonka Lennonka deleted the add-secureboot-vmware branch February 4, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximiliankolb maximiliankolb maximiliankolb left review comments

@nofaralfasi nofaralfasi Awaiting requested review from nofaralfasi

+1 more reviewer

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective testing done No issues from the functional perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Lennonka @maximiliankolb @Gauravtalreja1 @nofaralfasi