Skip to content

Correct default number of items per page #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lennonka merged 6 commits into from
Jan 14, 2026
Merged

Correct default number of items per page #4312

Lennonka merged 6 commits into from
Jan 14, 2026

Conversation

@waldirio
Copy link
Contributor

@waldirio waldirio commented Sep 26, 2025 •
edited by Lennonka
Loading

What changes are you introducing?

Fixing the wrong information.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

It's not accurate.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Sep 26, 2025
@github-actions
Copy link

github-actions bot commented Sep 26, 2025 •
edited
Loading

The PR preview for 34ab48d is available at theforeman-foreman-documentation-preview-pr-4312.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

Lennonka
Lennonka requested changes Sep 29, 2025
View reviewed changes
@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author Needs re-review and removed Waiting on contributor Requires an action from the author Needs re-review labels Sep 29, 2025
@ekohl ekohl changed the title Fixes_38779 - Fixing the wrong information in the doc Correct default number of items per page Sep 29, 2025
Lennonka
Lennonka requested changes Sep 29, 2025
View reviewed changes
@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author Needs re-review and removed Waiting on contributor Requires an action from the author Needs re-review labels Sep 29, 2025
Lennonka
Lennonka requested changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author Needs re-review and removed Waiting on contributor Requires an action from the author Needs re-review labels Sep 29, 2025
@aneta-petrova aneta-petrova added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Sep 30, 2025
@aneta-petrova
Copy link
Member

aneta-petrova commented Sep 30, 2025

Thanks @waldirio! You have my ack :) Now we need a tech ack to confirm the technical validity of the change. I'll ask the engineers.

@aneta-petrova
Copy link
Member

aneta-petrova commented Sep 30, 2025

@waldirio Do you happen to know which versions of Foreman/Satellite this applies to? Just so we know which versions the fix should be cherry-picked to.

@aneta-petrova aneta-petrova added testing done No issues from the functional perspective and removed Needs testing Requires functional testing labels Sep 30, 2025
@aneta-petrova
Copy link
Member

aneta-petrova commented Sep 30, 2025

I'm setting testing done per the report and conversation in https://issues.redhat.com/browse/SAT-35429.

ekohl
ekohl reviewed Sep 30, 2025
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention the entries_per_page setting?

@maximiliankolb
Copy link
Contributor

maximiliankolb commented Dec 12, 2025

@waldirio Can you please rebase your PR to HEAD of "master"?

@maximiliankolb
Copy link
Contributor

maximiliankolb commented Jan 8, 2026

triage: @waldirio Can you please rebase your PR to HEAD of "master"?

@waldirio
Copy link
Contributor Author

waldirio commented Jan 10, 2026

Hello @maximiliankolb

Rebased! Please, let me know if you need anything else.

Thank you!
Waldirio

@waldirio
Copy link
Contributor Author

waldirio commented Jan 12, 2026

@ekohl @Lennonka good morning

Updated. Please, let me know if you need anything else.
Waldirio

@Lennonka
Copy link
Contributor

Lennonka commented Jan 12, 2026 •
edited
Loading

Since that was @ekohl's only concern, I think we can consider this PR tech acked.

We'll still keep it open for a couple more hours for additional comments.

@Lennonka Lennonka added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Jan 12, 2026
@Lennonka
Copy link
Contributor

Lennonka commented Jan 12, 2026 •
edited
Loading

@waldirio Can you, please, answer this comment by @aneta-petrova?

Do you happen to know which versions of Foreman/Satellite this applies to? Just so we know which versions the fix should be cherry-picked to.

@waldirio
Copy link
Contributor Author

waldirio commented Jan 12, 2026

@waldirio Do you happen to know which versions of Foreman/Satellite this applies to? Just so we know which versions the fix should be cherry-picked to.

Hello, sorry that I missed that. No idea about which version this was opened, but I can confirm that this behavior is valid for all of them.

Thank you!
Waldirio

@Lennonka
Copy link
Contributor

Lennonka commented Jan 12, 2026

Updated the PR description. We no longer cherry pick to 3.11 and older.

maximiliankolb
maximiliankolb approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone.

@Lennonka Lennonka merged commit 0d4655a into theforeman:master Jan 14, 2026
9 of 10 checks passed
Lennonka pushed a commit that referenced this pull request Jan 14, 2026
@waldirio @Lennonka
Correct default number of items per page (#4312)
26e15fe
Lennonka pushed a commit that referenced this pull request Jan 14, 2026
@waldirio @Lennonka
Correct default number of items per page (#4312)
d87d10f
Lennonka pushed a commit that referenced this pull request Jan 14, 2026
@waldirio @Lennonka
Correct default number of items per page (#4312)
2ad52a0
Lennonka pushed a commit that referenced this pull request Jan 14, 2026
@waldirio @Lennonka
Correct default number of items per page (#4312)
8b0f690
Lennonka pushed a commit that referenced this pull request Jan 14, 2026
@waldirio @Lennonka
Correct default number of items per page (#4312)
e9b9a0b
@Lennonka
Copy link
Contributor

Lennonka commented Jan 14, 2026

Cherry picked:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekohl ekohl ekohl left review comments

@aneta-petrova aneta-petrova aneta-petrova approved these changes

@Lennonka Lennonka Lennonka requested changes

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees

No one assigned

Labels

style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective testing done No issues from the functional perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@waldirio @aneta-petrova @maximiliankolb @Lennonka @ekohl