Skip to content

Conversation

@Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Dec 18, 2025

What changes are you introducing?

DITA-fying the Managing content views chapter in the Managing content guide

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

DITA compliance

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

  • Abstracts will be reviewed later.
  • I've simplified some things.

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Dec 18, 2025
@Lennonka Lennonka removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Dec 18, 2025
@Lennonka Lennonka marked this pull request as ready for review December 18, 2025 04:28
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

35/44

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

44/44. Overall LGTM; I made some more minor suggestions. Please rebase to HEAD of "master".

@pr-processor pr-processor bot added the Waiting on contributor Requires an action from the author label Dec 19, 2025
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Jan 14, 2026
Lennonka and others added 2 commits January 14, 2026 02:25
@Lennonka Lennonka force-pushed the comply-dita-mng-content-cvs branch from ae0b3bd to 7a4873f Compare January 14, 2026 01:25
@Lennonka
Copy link
Contributor Author

Rebased.

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two tiny suggestions, rest LGTM.

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jan 14, 2026
@Lennonka Lennonka merged commit 36d0b80 into theforeman:master Jan 14, 2026
10 checks passed
Lennonka added a commit that referenced this pull request Jan 14, 2026
Lennonka added a commit that referenced this pull request Jan 14, 2026
@Lennonka
Copy link
Contributor Author

Cherry picked:

@Lennonka Lennonka deleted the comply-dita-mng-content-cvs branch January 14, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

style review done No issues from docs style/grammar perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants