Skip to content

Fix xref to import GPG pub key for SUSE content #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maximiliankolb merged 1 commit into from
Jan 8, 2026
Merged

Fix xref to import GPG pub key for SUSE content #4561

maximiliankolb merged 1 commit into from
Jan 8, 2026
+3 −3

Conversation

@maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb commented Jan 5, 2026

What changes are you introducing?

  • Fix broken xref
  • This patch also drops "Optional:" to avoid telling users that security is optional.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Error was introduced via #4404 or earlier

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@maximiliankolb
Fix xref to import GPG pub key for SUSE content
83c9250 
This patch also drops "Optional:" to avoid telling users that security
is optional.
@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Jan 5, 2026
@maximiliankolb maximiliankolb removed Needs tech review Requires a review from the technical perspective Not yet reviewed Needs testing Requires functional testing labels Jan 5, 2026
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

The PR preview for 83c9250 is available at theforeman-foreman-documentation-preview-pr-4561.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jan 5, 2026
@maximiliankolb maximiliankolb merged commit d435202 into theforeman:master Jan 8, 2026
10 of 11 checks passed
@maximiliankolb maximiliankolb deleted the fix_broken_xrefs branch January 8, 2026 07:24
maximiliankolb added a commit that referenced this pull request Jan 8, 2026
@maximiliankolb
Fix xref to import GPG pub key for SUSE content (#4561)
ea5ebc8 
This patch also drops "Optional:" to avoid telling users that security
is optional.

(cherry picked from commit d435202)
maximiliankolb added a commit that referenced this pull request Jan 8, 2026
@maximiliankolb
Fix xref to import GPG pub key for SUSE content (#4561)
10d7e35 
This patch also drops "Optional:" to avoid telling users that security
is optional.

(cherry picked from commit d435202)
@maximiliankolb
Copy link
Contributor Author

maximiliankolb commented Jan 8, 2026

Merged to "master" and cherry-picked:
a62c70d..ea5ebc8 3.17 -> 3.17
70503f0..10d7e35 3.16 -> 3.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aneta-petrova aneta-petrova aneta-petrova approved these changes

Assignees

No one assigned

Labels

style review done No issues from docs style/grammar perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maximiliankolb @aneta-petrova