build foremanctl guide base to have something to compare against #4566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Needs tech review
11 tasks
|
The PR preview for 9254d4c is available at theforeman-foreman-documentation-preview-pr-4566.surge.sh No diff compared to the current base |
evgeni
commented
Jan 6, 2026
Comment on lines
121
to
128
| make -j ${{ env.MAKE_J }} html BUILD=foreman-el | ||
| make -j ${{ env.MAKE_J }} html BUILD=foreman-deb | ||
| make -j ${{ env.MAKE_J }} html BUILD=foremanctl-katello | ||
| make -j ${{ env.MAKE_J }} html BUILD=foremanctl-orcharhino | ||
| make -j ${{ env.MAKE_J }} html BUILD=foremanctl-satellite | ||
| make -j ${{ env.MAKE_J }} html BUILD=katello | ||
| make -j ${{ env.MAKE_J }} html BUILD=satellite | ||
| make -j ${{ env.MAKE_J }} html BUILD=orcharhino |
Member
Author
There was a problem hiding this comment.
it might be smarter to just use make html from the main Makefile instead of calling html for each BUILD in guides/Makefile, but I didn't want to create more structural changes.
Member
Author
|
#4564 did the same 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: b27cba4
What changes are you introducing?
Enable building
foremanctlguides when building the "base" a PR is diffed againstWhy are you introducing these changes? (Explanation, links to references, issues, etc.)
So that the diff doesn't show all of
foremanctlas new all the time.Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: