Skip to content

Reword unprotected file repositories - #5089

Open
maximiliankolb wants to merge 1 commit into
theforeman:masterfrom
ATIX-AG:reword_protected_file_repositories
Open

Reword unprotected file repositories#5089
maximiliankolb wants to merge 1 commit into
theforeman:masterfrom
ATIX-AG:reword_protected_file_repositories

Conversation

@maximiliankolb

Copy link
Copy Markdown
Contributor

What changes are you introducing?

If a file repository is unprotected, anyone that can connect to Foreman+Katello can download files via curl.

If a file repository is protected, you need a valid debug certificate or entitlement.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Protected/unprotected does not relate to transport security/HTTP vs HTTPS.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Refs PR #5056

Tested on Foreman 3.18/Katello 4.20 with a self-signed certificate. wget always redirected me from http://foreman.example.com/... to https://foreman.example.com/.... -> I could not access the file over plain HTTP due to HSTS: URL transformed to HTTPS due to an HSTS policy.

I also did not try to use a debug certificate/entitlement; I just tested that you cannot access it without: 403: [('PEM routines', '', 'no start line')].

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.19/Katello 4.21
  • Foreman 3.18/Katello 4.20 (Satellite 6.19; orcharhino 7.9)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6, 7.7, and 7.8)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • We do not accept PRs for Foreman older than 3.14.

If a file repository is unprotected, anyone that can connect to
Foreman+Katello can download files via curl.

If a file repository is protected, you need a valid debug certificate or
entitlement.

Protected/unprotected does not relate to transport security/HTTP vs
HTTPS.

Refs PR theforeman#5056
@github-actions github-actions Bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Jul 21, 2026
@github-actions

Copy link
Copy Markdown

The PR preview for 579cab4 is available at theforeman-foreman-documentation-preview-pr-5089.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@aneta-petrova aneta-petrova added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jul 21, 2026
@maximiliankolb

Copy link
Copy Markdown
Contributor Author

@jeremylenz Can you please do a tech review?

@jeremylenz jeremylenz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem correct to me, but tagging @sjha4 and @ianballou to clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing style review done No issues from docs style/grammar perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants