Skip to content

Containerize Remote Execution section - #5093

Open
AkshayGadhaveRH wants to merge 1 commit into
theforeman:masterfrom
AkshayGadhaveRH:containerized-rex
Open

Containerize Remote Execution section#5093
AkshayGadhaveRH wants to merge 1 commit into
theforeman:masterfrom
AkshayGadhaveRH:containerized-rex

Conversation

@AkshayGadhaveRH

@AkshayGadhaveRH AkshayGadhaveRH commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

JIRA:wq
https://redhat.atlassian.net/browse/SAT-41055

What changes are you introducing?

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.19/Katello 4.21
  • Foreman 3.18/Katello 4.20 (Satellite 6.19; orcharhino 7.9)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6, 7.7, and 7.8)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • We do not accept PRs for Foreman older than 3.14.

@github-actions github-actions Bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Jul 22, 2026
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

@adamruzicka

Copy link
Copy Markdown
Contributor

Should this also address how the plugin can be enabled in containerized deployments where it is not enabled by default?

Something along the lines of an additional ifdef and {{foremanctl}} --add-feature remote-execution in guides/common/modules/proc_installing-the-remote-execution-plugin.adoc

@adamruzicka

Copy link
Copy Markdown
Contributor

ping on the previous comment

@jafiala

jafiala commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

I think this was already addressed in https://github.com/theforeman/foreman-documentation/pull/5092/changes. Unfortunately, I did not squish the commits so the history on master is a mess :/

@adamruzicka

Copy link
Copy Markdown
Contributor

Looks like documentation moves fast. I'm surprised that this pr has no conflicts.

Anyway, what about my original point, which doesn't seem to be addressed in 5092 either?

@maximiliankolb

Copy link
Copy Markdown
Contributor

Looks like documentation moves fast. I'm surprised that this pr has no conflicts.

There's a merge conflict by now @AkshayGadhaveRH Please rebase your PR to HEAD of "master".

@maximiliankolb maximiliankolb added the Waiting on contributor Requires an action from the author label Aug 6, 2026
Comment thread guides/common/modules/con_transport-modes-for-remote-execution.adoc Outdated
@pr-processor pr-processor Bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Aug 6, 2026

@maximiliankolb maximiliankolb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style-wise LGTM

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Aug 7, 2026
@@ -9,6 +9,13 @@ You can install and enable the Remote Execution plugin to run commands and jobs
.Procedure
. Install the Remote Execution plugin on your {ProjectServer}:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading it correctly, then for containerized builds this would result in a list with a single ordered item. -> Should be unordered for containerized and ordered for all others.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

Suggested change
. Install the Remote Execution plugin on your {ProjectServer}:
ifdef::containerized[]
* Install the Remote Execution plugin on your {ProjectServer}:
endif::[]
ifndef::containerized[]
. Install the Remote Execution plugin on your {ProjectServer}:
endif::[]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I had a good teacher :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing style review done No issues from docs style/grammar perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants