Containerize Remote Execution section - #5093
Conversation
|
The PR preview for 13b3477 is available at theforeman-foreman-documentation-preview-pr-5093.surge.sh The following output files are affected by this PR: |
|
Should this also address how the plugin can be enabled in containerized deployments where it is not enabled by default? Something along the lines of an additional ifdef and |
|
ping on the previous comment |
|
I think this was already addressed in https://github.com/theforeman/foreman-documentation/pull/5092/changes. Unfortunately, I did not squish the commits so the history on master is a mess :/ |
|
Looks like documentation moves fast. I'm surprised that this pr has no conflicts. Anyway, what about my original point, which doesn't seem to be addressed in 5092 either? |
There's a merge conflict by now @AkshayGadhaveRH Please rebase your PR to HEAD of "master". |
22bfd4a to
46c604e
Compare
46c604e to
13b3477
Compare
| @@ -9,6 +9,13 @@ You can install and enable the Remote Execution plugin to run commands and jobs | |||
| .Procedure | |||
| . Install the Remote Execution plugin on your {ProjectServer}: | |||
There was a problem hiding this comment.
If I'm reading it correctly, then for containerized builds this would result in a list with a single ordered item. -> Should be unordered for containerized and ordered for all others.
There was a problem hiding this comment.
nice catch!
| . Install the Remote Execution plugin on your {ProjectServer}: | |
| ifdef::containerized[] | |
| * Install the Remote Execution plugin on your {ProjectServer}: | |
| endif::[] | |
| ifndef::containerized[] | |
| . Install the Remote Execution plugin on your {ProjectServer}: | |
| endif::[] |
There was a problem hiding this comment.
Well, I had a good teacher :)
JIRA:wq
https://redhat.atlassian.net/browse/SAT-41055
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: