Add foremanctl commands for IoP - #5096
Conversation
github-actions
Bot
added
Needs tech review
| ---- | ||
| endif::[] | ||
| ifdef::containerized[] | ||
| .. Create a `config.yml` file that includes the following logging levels together with the required IOP core engine configuration: |
There was a problem hiding this comment.
I would either say "IoP" or use the attribute https://github.com/theforeman/foreman-documentation/blob/master/guides/common/attributes-base.adoc#L174
same applies to line 76.
| ---- | ||
| # {foreman-installer} --enable-iop | ||
| ifndef::containerized[# {foreman-installer} --enable-iop] | ||
| ifdef::containerized[# {foremanctl} deploy --add-feature iop] |
There was a problem hiding this comment.
if it's the same like line 24, then maybe a different structure is better because users do not need to know if they used IoP before.
|
@maximiliankolb Thanks a lot for your notes! I will need a tech review first because it will decide how to proceed further. |
82569d4 to
2040262
Compare
| "": | ||
| level: "DEBUG" | ||
| ---- | ||
| .. Replace the `iop-core-engine-config-yml` Podman secret: |
There was a problem hiding this comment.
I don't love this as a procedure that we are telling users to do. @vkrizan Do you think we should add this as a logging option in foremanctl ?
There was a problem hiding this comment.
Agreed. This goes against our design guidelines and is something that should be addressed. IMHO we can't release this in the current state.
There was a problem hiding this comment.
Agreed. I'd skip this "hack" part for now.
0dfcb0c to
4986cc4
Compare
4986cc4 to
314c2a9
Compare
Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
5 participants
What changes are you introducing?
Adding foremanctl commands for IoP in containerized Foreman:
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Containerization
SAT-40194
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: N/A