Combine modules to provision hosts on Proxmox/VMware - #5149
Open
maximiliankolb wants to merge 4 commits into
Open
Combine modules to provision hosts on Proxmox/VMware#5149maximiliankolb wants to merge 4 commits into
maximiliankolb wants to merge 4 commits into
Conversation
github-actions
Bot
added
Needs tech review
|
The PR preview for d9f0d93 is available at theforeman-foreman-documentation-preview-pr-5149.surge.sh The following output files are affected by this PR: |
Contributor
Author
|
The comment by vale about |
Contributor
Author
|
follow-up: maybe merge |
jafiala
approved these changes
Aug 5, 2026
jafiala
left a comment
jafiala
left a comment
Contributor
There was a problem hiding this comment.
One question, otherwise LGTM
This patch aims to unify the modules to provision hosts on Promox and other compute resources. It simplifies future maintenance. It does not break any links.
This patch aims to unify the modules to provision hosts on VMware and other compute resources. It simplifies future maintenance. It does not break any links.
By using an attribute, we can deduplicate content for Proxmox and VMware-based host provisioning.
maximiliankolb
force-pushed
the
unify_provisioning_a_host
branch
from
August 6, 2026 05:55
16d5049 to
d9f0d93
Compare
maximiliankolb
commented
Aug 6, 2026
maximiliankolb
left a comment
maximiliankolb
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks @jafiala for catching an error. I rebased my PR to HEAD of "master" and applied your suggestion. Ready for re-review.
maximiliankolb
added
style review done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
This PR aims to merge duplicate modules to create hosts: we have a generic module and two modules for VMware and Proxmox.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
To deduplicate content & because I want to extend the steps in a follow-up PR.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
This PR does not break any links; provisioning a host on Proxmox via Hammer CLI is untested -> I did not add it with this PR.
Contributor checklists
Please cherry-pick my commits into: