3.17: Remove orphaned files - #5153
Open
jafiala wants to merge 3 commits into
Open
Conversation
|
The PR preview for 17a64bd is available at theforeman-foreman-documentation-preview-pr-5153.surge.sh The following output files are affected by this PR: |
jafiala
marked this pull request as ready for review
August 5, 2026 10:32
Member
For this file, can you please add it to Managing Hosts rather than delete it? This would be the right place: |
Member
This one should be safe to delete. The only issue seems to be that because the new module from master isn't used on 3.17, the corresponding module on 3.17 still has links in the concept. I'll look into that right away in a different PR. EDIT: #5154 |
8 tasks
Contributor
Author
|
Thanks @aneta-petrova , restored and included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Delete 6 module files that are orphaned on the 3.17 branch:
con_boot-loader-management-and-file-structure.adocref_boot-loader-types-in-project.adocref_http-capable-boot-loaders.adocref_pxelinux-boot-loaders.adoccon_configuring-smart-proxy-servers-with-a-custom-ssl-certificate.adocproc_running-an-ansible-playbook.adocThese files are not included by any assembly or guide on 3.17, causing the
find_unused_modulesCI check to fail for all PRs targeting this branch.Why are you introducing these changes? (Explanation, links to references, issues, etc.)
These modules exist on
masterand are properly included there, but ended up on3.17through incomplete cherry-picks:assembly_bootloader-binary-location.adoc, created in PR Add section "Boot loader management and file structure" #4422) was never backported to 3.17.proc_running-an-ansible-playbook.adocwas moved from the Ansible guide toassembly_configuring-and-setting-up-remote-jobs.adocin PR Review Managing Configurations by using Ansible for CQA #4818, but only the removal from the Ansible guide was cherry-picked — the new include was not added to the assembly on 3.17.con_configuring-smart-proxy-servers-with-a-custom-ssl-certificate.adocwas created by PR Fix asciidoctor-dita-vale errors for the ConceptLink rule #4801 (ConceptLink fixes), but the corresponding include inassembly_installing-smart-proxy-server.adocwas never added on 3.17.Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
These modules remain on
masterwhere they are properly included. An alternative would have been backporting the missing assemblies and includes to 3.17, but since 3.17 is a release branch and the content was never published there, deletion is the simpler and safer approach.Contributor checklists
Please cherry-pick my commits into: