Add CV assemblies to containerized guide - #5155
Open
aneta-petrova wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
Needs tech review
aneta-petrova
removed
Needs tech review
Member
Author
|
This fails because of xrefs to the activation keys assembly, which is being added in #5143. I'll try waiting for that PR to be reviewed and acked rather than disabling the xrefs. |
|
The PR preview for 3d3670d is available at theforeman-foreman-documentation-preview-pr-5155.surge.sh The following output files are affected by this PR: |
aneta-petrova
force-pushed
the
foremanctl-cvs
branch
from
August 6, 2026 12:21
7957b31 to
3d3670d
Compare
aneta-petrova
marked this pull request as ready for review
August 6, 2026 12:26
aneta-petrova
added
Needs tech review
8 tasks
maximiliankolb
left a comment
maximiliankolb
left a comment
Contributor
There was a problem hiding this comment.
one small comment, overall LGTM
| ifdef::katello,orcharhino[] | ||
| include::common/assembly_managing-suse-content.adoc[leveloffset=+1] | ||
| endif::[] | ||
| endif::[] |
Contributor
There was a problem hiding this comment.
Suggested change
| endif::[] |
| endif::[] | ||
|
|
||
| ifndef::containerized[] | ||
| ifdef::katello,satellite,orcharhino[] |
Contributor
There was a problem hiding this comment.
My suggested diff looks weird but IMO you could drop line 82 and 86.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Exposing assemblies related to content views in containerized guides, namely "Managing content views and content view environments" and "Making errata available through content views".
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
To extend our containerized docs set.
https://redhat.atlassian.net/browse/SAT-47727
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
N/A
Contributor checklists
Please cherry-pick my commits into: