Skip to content

build proxy plugins on el9 #10220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
evgeni merged 5 commits into from
Jan 5, 2024
Merged

build proxy plugins on el9 #10220

evgeni merged 5 commits into from
Jan 5, 2024

Conversation

@evgeni
Copy link
Member

@evgeni evgeni commented Jan 5, 2024

No description provided.

@evgeni
Copy link
Member Author

evgeni commented Jan 5, 2024 •
edited
Loading

shall we explicitly set the non-el9 copr config for those for now?

@evgeni evgeni marked this pull request as ready for review January 5, 2024 14:05
evgeni
evgeni commented Jan 5, 2024
View reviewed changes
@ekohl
Copy link
Member

ekohl commented Jan 5, 2024

smart_proxy_pulp needs

We already have Ruby 3.0 & 3.1 testing in Jenkins, so I'd argue it's not needed.

@evgeni
Copy link
Member Author

evgeni commented Jan 5, 2024 •
edited
Loading

smart_proxy_pulp needs

We already have Ruby 3.0 & 3.1 testing in Jenkins, so I'd argue it's not needed.

If you look at the PR, it also adjusts the gemspec to allow 3.0, I can submit that as an own PR though.

And there is no Jenkins run in the PR?

ekohl
ekohl approved these changes Jan 5, 2024
View reviewed changes
package_manifest.yaml
Comment on lines +885 to +889
rubygem-httparty: {}
rubygem-infoblox: {}
rubygem-logify: {}
rubygem-mqtt: {}
rubygem-multi_xml: {}
Copy link
Member

@ekohl ekohl Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look correct: they're only mentioned in the plugin comps.

@ekohl
Copy link
Member

ekohl commented Jan 5, 2024

And there is no Jenkins run in the PR?

Are you confusing it with the smart_proxy_container_gateway PR? I was talking about smart_proxy_pulp.

@evgeni evgeni merged commit 1b96867 into rpm/develop Jan 5, 2024
@evgeni evgeni deleted the proxy-plugins-el9 branch January 5, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekohl ekohl ekohl approved these changes

Assignees

No one assigned

Labels

RPM

Projects

No open projects
EL 9 support
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evgeni @ekohl