Skip to content

Conversation

@bastelfreak
Copy link
Member

No description provided.

@bastelfreak
Copy link
Member Author

This fails because it depends on the ruby-concurrent gem. But I'm not sure how to proceed here.

@bastelfreak
Copy link
Member Author

rubygem-concurrent-ruby is in EPEL9 \o/

@ekohl
Copy link
Member

ekohl commented Nov 7, 2025

rubygem-concurrent-ruby is in EPEL9 \o/

We shouldn't depend on EPEL, but have packaged it ourselves.

[2025-11-07T18:47:21.480Z]             (rubygem(concurrent-ruby) >= 1.3 with rubygem(concurrent-ruby) < 2 with rubygem(concurrent-ruby) >= 1.3.5)

We have packaged 1.1.10. I'm not sure if we could update it. From https://github.com/theforeman/foreman-packaging/actions/runs/19091008446/job/54541589251

Found conflict for rubygem-concurrent-ruby: 1.1.10 (foreman) != 1.3.5 (smart-proxy)

The job archives the Gemfile.lock from Foreman: https://ci.theforeman.org/view/Foreman%20Nightly/job/foreman-develop-source-release/3019/artifact/Gemfile.lock/*view*/

Looks like this is because of dynflow (https://rubygems.org/gems/dynflow/versions/1.9.3) that has a specific pin on `~> 1.1.3``. Dynflow/dynflow#424 was opened a long time ago, so perhaps it's time to rebase that.

@bastelfreak bastelfreak requested review from a team as code owners November 10, 2025 10:41
@bastelfreak
Copy link
Member Author

I tested around and the plugin smart_proxy_openbolt is compatible with concurrent-ruby 1.1.10. I released smart_proxy_openbolt 0.1.0, which depends now on concurrent-ruby 1.1.10, and run ./bump_rpm.sh packages/plugins/rubygem-smart_proxy_openbolt/. Shouldn't that add concurrent-ruby to the spec file, or do I have to do this manually?

The ruby gem has the proper dependency: https://rubygems.org/gems/smart_proxy_openbolt/versions/0.1.0

@evgeni evgeni merged commit 1f1af2e into theforeman:rpm/develop Nov 10, 2025
3 checks passed
@evgeni
Copy link
Member

evgeni commented Nov 10, 2025

It doesn't need to be in the spec file, no, it is a runtime dep and:

% rpm -q --requires -p ./rubygem-smart_proxy_openbolt-0.1.0-1.fm3_17.el9.noarch.rpm 
(rubygem(concurrent-ruby) >= 1.1.10 with rubygem(concurrent-ruby) < 2)
…

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the party, but could you follow up on my comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants