Skip to content

Conversation

@adamruzicka
Copy link
Contributor

@adamruzicka adamruzicka commented Oct 22, 2025

# for i in locale/{fr,ja,ko,zh_CN}/*.po ; do msgfmt -vvv -o /dev/null "$i"; done 2>&1 | grep -v .edit.po | sort | grep untranslated
locale/fr/foreman_tasks.po: 293 translated messages, 2 untranslated messages.
locale/ja/foreman_tasks.po: 293 translated messages, 2 untranslated messages.
locale/ko/foreman_tasks.po: 293 translated messages, 2 untranslated messages.
locale/zh_CN/foreman_tasks.po: 293 translated messages, 2 untranslated messages.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the Makefile changes, but they look good to me. Thanks!

@adamlazik1
Copy link
Contributor

Probably ready to be merged after rebase.

@adamruzicka
Copy link
Contributor Author

🍏

@adamlazik1
Copy link
Contributor

@adamruzicka one last thing that came to mind: Could you merge first and second commit together?

@adamruzicka
Copy link
Contributor Author

Squashed and green again

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't object to merging this now, but we should do another translation round. So right now I'd focus on the .pot file being complete and getting the infrastructure in place so in the future it will continue to work. The latter looks good, but see the inline comment for the former.

msgstr ""

#: action_names.rb:2
msgid "Action with sub plans"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this come from? I can't find the source for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the result of calling #humanized_name on an instance of Actions::ActionWithSubPlans from gettext:store_action_names

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks

@adamlazik1 adamlazik1 merged commit e598c5d into theforeman:master Oct 24, 2025
16 of 17 checks passed
@adamlazik1
Copy link
Contributor

Thanks @adamruzicka and @ekohl!

@adamruzicka adamruzicka deleted the i18n branch October 24, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants