-
Notifications
You must be signed in to change notification settings - Fork 98
i18n - pulling from tx #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ekohl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test the Makefile changes, but they look good to me. Thanks!
|
Probably ready to be merged after rebase. |
|
🍏 |
|
@adamruzicka one last thing that came to mind: Could you merge first and second commit together? |
|
Squashed and green again |
ekohl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't object to merging this now, but we should do another translation round. So right now I'd focus on the .pot file being complete and getting the infrastructure in place so in the future it will continue to work. The latter looks good, but see the inline comment for the former.
| msgstr "" | ||
|
|
||
| #: action_names.rb:2 | ||
| msgid "Action with sub plans" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this come from? I can't find the source for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the result of calling #humanized_name on an instance of Actions::ActionWithSubPlans from gettext:store_action_names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks
|
Thanks @adamruzicka and @ekohl! |
Uh oh!
There was an error while loading. Please reload this page.