Fix failing tests #784
Merged
Fix failing tests #784
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
reviewed
Oct 23, 2025
| # console no matter what task it is... | ||
| edit_permission = Permission.where(:name => :edit_foreman_tasks, :resource_type => ForemanTasks::Task.name).first | ||
| if @user.filters.joins(:filterings).unlimited.where('filterings.permission_id' => edit_permission).first | ||
| if @user.filters.joins(:filterings).where('filterings.permission_id' => edit_permission).any? { |f| f.search_condition.blank? } |
Contributor
There was a problem hiding this comment.
The unlimited scope was originally defined like this:
scope :unlimited, -> { where(:search => nil, :taxonomy_search => nil) }
I'd prefer to add this to the where condition to keep the behaviour exactly the same as it used to be.
adamruzicka
reviewed
Oct 23, 2025
theforeman/foreman#10370 made changes to filters which must be addressed here for tests to pass.
adamruzicka
approved these changes
Oct 24, 2025
Contributor
|
Thank you @adamlazik1 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
theforeman/foreman#10370 made changes to filters which must be addressed here for tests to pass.