Support for Dynflow chaining #786
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
reviewed
Nov 4, 2025
Comment on lines
+75
to
+81
| begin | ||
| delayed_plan = dynflow.world.persistence.load_delayed_plan(result.id) | ||
| execution_plan = dynflow.world.persistence.load_execution_plan(result.id) | ||
| ForemanTasks::Task::DynflowTask.new_for_execution_plan(execution_plan).tap do |task| | ||
| task.update_from_dynflow(execution_plan, delayed_plan) | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
Is this really necessary? Chaining is "just" a special case of delay, for which we don't do this
Contributor
Author
There was a problem hiding this comment.
I thought I needed this for it to be visible as a scheduled task in the ForemanTasks browser, but I can revisit that.
Eh, scratch that. I can probably remove this. Let me just double check that there wasn't a corner case why we needed to update the task, I can't remember now.
Contributor
Author
|
Closing, this is unnecessary. |
Contributor
|
I would still prefer to have this explicitly exposed in foreman-tasks, but maybe change the interface so that it takes task uuids (as opposed to internal dynflow uuids) or maybe even whole tasks or task scopes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ForemanTasks support for Dynflow/dynflow#446. Creates a Task for the chained Dynflow Task. This implementation is quite basic, so let me know if there are improvements that can be made.