Fixes #38549 - Add WOL capability to Host #10599
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The merge order should be:
This whole effort is nice to have and there's no rush getting it in. |
ares
force-pushed
the
fix/38549
branch
2 times, most recently
from
3a48195 to
915ef05
Compare
Member
Author
|
Ah, there are some test failures I missed locally, I'll need to fix those first. Think of it as a draft meanwhile. |
Member
Author
|
Also adding the UI demonstration |
The feature adds the ability to wake suspended Host by Wake on LAN. It requires a smart proxy with WOL feature. Typically, when host has a network interface attached to a subnet where we manage the DHCP, the broadcast in such network is available. That's due to the core principle of DHCP protocol. In such network, it's possible to perform WOL, which also relies on broadcast. This patch adds WOL support for Host's primary interface as that's the one we run the DHCP orchestration on. This could be extended in future if we see the need to specify other host interface instead. The Host's API loads the primary interface, checks the presence of the DHCP proxy and it's WOL capability. If it is available, it triggers the relevant API on the smart proxy and displays a toast notification. This new action reuses the same permission we have for BMC (power management of the host).
MariaAga
reviewed
Sep 26, 2025
| @@ -0,0 +1,13 @@ | |||
| import { testActionSnapshotWithFixtures } from '../../../../common/testHelpers'; | |||
Member
There was a problem hiding this comment.
We are moving away from testActionSnapshotWithFixtures see https://github.com/theforeman/foreman/blob/develop/developer_docs/ui-testing-guidelines.asciidoc for ui test guidelines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature adds the ability to wake suspended Host by Wake on LAN. It
requires a smart proxy with WOL feature.
Typically, when host has a network interface attached to a subnet where
we manage the DHCP, the broadcast in such network is available. That's
due to the core principle of DHCP protocol. In such network, it's
possible to perform WOL, which also relies on broadcast. This patch adds
WOL support for Host's primary interface as that's the one we run the
DHCP orchestration on. This could be extended in future if we see the
need to specify other host interface instead.
The Host's API loads the primary interface, checks the presence of the
DHCP proxy and it's WOL capability. If it is available, it triggers the
relevant API on the smart proxy and displays a toast notification.
This new action reuses the same permission we have for BMC (power
management of the host).