Skip to content

Conversation

@stejskalleos
Copy link
Contributor

If a subnet has only a BMC proxy assigned,
this smart proxy will be ignored in the host.smart_proxies results.

This fix includes BMC proxies in the result.

Found during the testing of #10561 (power_action_v2 method)

If a subnet has only a BMC proxy assigned,
this smart proxy will be ignored in the host.smart_proxies results.

This fix includes BMC proxies in the result.
@stejskalleos stejskalleos merged commit a271812 into theforeman:develop Sep 23, 2025
98 of 102 checks passed
@adamruzicka
Copy link
Contributor

Oh, this went in fast.

I was wondering if rather than manually building a list, we could leverage smart proxy references instead? We wouldn't have to maintain a list here and we wouldn't have to extend said list from plugins.

Something along the lines of this

def smart_proxy_ids
  self.class.smart_proxy_ids(self.class.where(id: id))
end

Well, guess that ship has already sailed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants