Refs #38822: update pf3 buttons to pf5 - ConfigReports, ForemanModal/subcomponents #10766
+134
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kfamilonidis
force-pushed
the
pf5-buttons-config-reports
branch
2 times, most recently
from
6d0b38f to
6e2e9ed
Compare
kfamilonidis
force-pushed
the
pf5-buttons-config-reports
branch
from
6e2e9ed to
08e7d9d
Compare
kfamilonidis
changed the title
kfamilonidis
force-pushed
the
pf5-buttons-config-reports
branch
2 times, most recently
from
f8c1db7 to
9271355
Compare
kfamilonidis
changed the title
kfamilonidis
force-pushed
the
pf5-buttons-config-reports
branch
from
9271355 to
0614bb4
Compare
kfamilonidis
changed the title
…subcomponents Upgrade DiffModal, DeleteButton, ForemanModalFooter/SubmitOrCancel Replace Enzyme tests with React Testing Library. Replace bgStyle with equivalent variant props.
kfamilonidis
force-pushed
the
pf5-buttons-config-reports
branch
from
0614bb4 to
96c7103
Compare
kfamilonidis
changed the title
adamlazik1
approved these changes
Dec 3, 2025
Contributor
adamlazik1
left a comment
adamlazik1
left a comment
There was a problem hiding this comment.
LGTM. Tested and verified on a packit build.
ofedoren
approved these changes
Dec 12, 2025
Member
ofedoren
left a comment
ofedoren
left a comment
There was a problem hiding this comment.
Based on SatelliteQE/robottelo#20489, I'd assume this won't break robottelo.
Thanks, @kfamilonidis and @adamlazik1
ofedoren
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade DiffModal, CancelButton, ForemanModal/subcomponents and replace Enzyme tests with React Testing Library. Replace bgStyle with equivalent variant props.
Acceptance Criteria:
DiffModal: close button in ConfigReportCancelButton: close button in ForemanModal/subcomponentsForemanModalFooter: close button in ForemanModal/subcomponentsSubmitOrCancel: in ForemanModal/subcomponentsfollowed by: #10767