-
Notifications
You must be signed in to change notification settings - Fork 1k
Fixes #38916 - Update EditorHostSelect to pf5 #10777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| import React, { Component } from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import { Select } from 'patternfly-react-extensions'; | ||
| import { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes are waiting to be integrated to this tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that #10728 should be merged first to leverage its passing tests. Subsequent changes can then be fully integrated with these tested, stable components.
kfamilonidis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good approach. It would help to cherry-pick these changes to align with the tests already written for this part here.
| "multiselect": "~0.9.12", | ||
| "number_helpers": "^0.1.1", | ||
| "os-browserify": "^0.3.0", | ||
| "patternfly-react-extensions": "^3.0.15", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting things from package.json will always get you a 📦 ACK from me ;-)
|
I didnt read the code yet, but isnt
The same as this pr? #10734 |
@MariaAga mostly the same but EditorHostSelect has some extra properties and I don't really know whether adjusting AutocompleteInput to replace EditorHostSelect won't break the use of AutocompleteInput in other places. |
|
Took a brief look at the changes and also at airgun:
|
I tried to replicate the behavior of https://v5-archive.patternfly.org/components/menus/select/#typeahead as much as possible, but that means that there are some differences from the pf3 EditorHostSelect. First host is no longer automatically used for preview. This can be easily reverted if desired.
Issues
Questions