Skip to content

Conversation

@adamlazik1
Copy link
Contributor

I tried to replicate the behavior of https://v5-archive.patternfly.org/components/menus/select/#typeahead as much as possible, but that means that there are some differences from the pf3 EditorHostSelect. First host is no longer automatically used for preview. This can be easily reverted if desired.

Issues

  • I haven't been able to fix the bottom margin of the Select after several attempts of inserting padding into various places. Any ideas how can I fix that?
image

Questions

  • How do we want to handle the case when hostname does not fit into the EditorHostSelect? I thought about adding a tooltip or making the font smaller.
image

@adamlazik1 adamlazik1 requested a review from a team as a code owner November 21, 2025 09:19
@github-actions github-actions bot added the UI label Nov 21, 2025
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import { Select } from 'patternfly-react-extensions';
import {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes are waiting to be integrated to this tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PRs do indeed seem intertwined. Do you think this PR should be rebased on #10728 or should this PR go first, then #10728 should be rebased on top of it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that #10728 should be merged first to leverage its passing tests. Subsequent changes can then be fully integrated with these tested, stable components.

Copy link
Contributor

@kfamilonidis kfamilonidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good approach. It would help to cherry-pick these changes to align with the tests already written for this part here.

"multiselect": "~0.9.12",
"number_helpers": "^0.1.1",
"os-browserify": "^0.3.0",
"patternfly-react-extensions": "^3.0.15",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting things from package.json will always get you a 📦 ACK from me ;-)

@MariaAga
Copy link
Member

I didnt read the code yet, but isnt

replicate the behavior of https://v5-archive.patternfly.org/components/menus/select/#typeahead

The same as this pr? #10734

@adamlazik1
Copy link
Contributor Author

I didnt read the code yet, but isnt

replicate the behavior of https://v5-archive.patternfly.org/components/menus/select/#typeahead

The same as this pr? #10734

@MariaAga mostly the same but EditorHostSelect has some extra properties and I don't really know whether adjusting AutocompleteInput to replace EditorHostSelect won't break the use of AutocompleteInput in other places.

@pondrejk
Copy link
Contributor

pondrejk commented Dec 3, 2025

Took a brief look at the changes and also at airgun:

  • I see editor-select-container stayed as an ID, which is great but I don't see it referenced in airgun anyway -- that's probably something to be changed, but this fact tells me that the tests doing template preview rely on the first host prefill, so in that matter this will definitely be a breaking change for ds tests. I'd like you to consider getting back to the fist item prefill, I think it was a nice click saver for users
  • the padding issue is definitely a problem for me, imho its ok to make the navbar thicker if we cant make the dropdown thinner
  • also I'd add some definition to the dropdown border, I imagine it would be hard to read, or maybe if it was with white background, not gray on gray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants