Fixes #38956 - Add cron rake tasks for recurring jobs #10784
+187
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2025
evgeni
reviewed
Dec 3, 2025
pr-processor
bot
added
Needs re-review
and removed
Not yet reviewed
Needs re-review
labels
Contributor
Author
|
Also the failure looks unrelated to the changes |
Member
Yepp, that's a regression in facterdb |
adamruzicka
reviewed
Dec 9, 2025
adamruzicka
reviewed
Dec 9, 2025
Member
|
The tests were fixed in #10794 -- if you rebase CI should turn green. I think |
archanaserver
force-pushed
the
cron-rake-tasks
branch
from
f1d3526 to
46d202e
Compare
archanaserver
force-pushed
the
cron-rake-tasks
branch
from
46d202e to
7512c2f
Compare
Contributor
Author
fair, working on it :/ |
archanaserver
force-pushed
the
cron-rake-tasks
branch
from
7512c2f to
569dad9
Compare
archanaserver
force-pushed
the
cron-rake-tasks
branch
from
569dad9 to
1a8978d
Compare
evgeni
reviewed
Dec 12, 2025
evgeni
reviewed
Dec 12, 2025
Member
|
This needs a redmine, and the test setup fixed, but other than that it looks good! Thanks! |
archanaserver
force-pushed
the
cron-rake-tasks
branch
from
1a8978d to
58f2f81
Compare
Contributor
Author
@evgeni seems like redmine is not accessible atm |
Member
Fixed it now. |
archanaserver
changed the title
archanaserver
force-pushed
the
cron-rake-tasks
branch
from
58f2f81 to
97b3515
Compare
archanaserver
force-pushed
the
cron-rake-tasks
branch
2 times, most recently
from
c600fe2 to
43d493c
Compare
Introduce `Foreman::Cron` with a hard-coded mapping from hourly/daily/weekly/monthly to existing rake tasks, and add `cron:hourly`, `cron:daily`, `cron:weekly` and `cron:monthly` rake tasks. These serve as generic entrypoints for scheduling (e.g. systemd timers in foremanctl) instead of wiring individual tasks. Allow plugins to register extra tasks in Foreman::Cron Fail cron:* rake tasks when a job fails Refine Foreman::Cron task Add unit tests for Foreman::Cron unified registry
archanaserver
force-pushed
the
cron-rake-tasks
branch
from
43d493c to
dd637c2
Compare
Contributor
Author
|
@evgeni i see that db fixture error is unrelated to this fix, and rest is working fine now. |
evgeni
reviewed
Dec 18, 2025
Comment on lines
+53
to
+55
| succeeding = mock('succeeding_task') | ||
| succeeding.expects(:reenable).once | ||
| succeeding.expects(:invoke).once |
Member
There was a problem hiding this comment.
The failure is related
Failure: test_0005_run returns true when a task fails but continues executing others
not all expectations were satisfied
unsatisfied expectations:
- expected exactly once, invoked never: #<Mock:succeeding_task>.invoke(any_parameters)
- expected exactly once, invoked never: #<Mock:succeeding_task>.reenable(any_parameters)
satisfied expectations:
- allowed any number of times, invoked never: #<AnyInstance:Resolv::DNS>.getaddresses(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Resolv::DNS>.getaddress(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Resolv::DNS>.getnames(any_parameters)
- allowed any number of times, invoked never: #<AnyInstance:Resolv::DNS>.getname(any_parameters)
- expected exactly once, invoked once: #<Mock:failing_task>.invoke(any_parameters)
- expected exactly once, invoked once: #<Mock:failing_task>.reenable(any_parameters)
- allowed any number of times, invoked never: Rake::Task.[]("second")
- allowed any number of times, invoked once: Rake::Task.[]("first")
Seems that the succeeding task is never executed?
evgeni
reviewed
Dec 19, 2025
Comment on lines
+69
to
+71
| def logger | ||
| @logger ||= Rails.logger | ||
| end |
Member
There was a problem hiding this comment.
Using the default Rails logger results in the logging to happen to /var/log/foreman/production.log, not stdout:
[root@ip-10-0-167-37 ~]# foreman-rake cron:hourly
W, [2025-12-19T02:10:18.445410 #202382] WARN -- : Scoped order is ignored, it's forced to be batch order.
W, [2025-12-19T02:10:18.775945 #202382] WARN -- : Scoped order is ignored, it's forced to be batch order.
W, [2025-12-19T02:10:18.992318 #202382] WARN -- : Scoped order is ignored, it's forced to be batch order.
W, [2025-12-19T02:10:19.055307 #202382] WARN -- : Scoped order is ignored, it's forced to be batch order.
W, [2025-12-19T02:10:19.271063 #202382] WARN -- : Scoped order is ignored, it's forced to be batch order.
W, [2025-12-19T02:10:19.523901 #202382] WARN -- : Scoped order is ignored, it's forced to be batch order.
[root@ip-10-0-167-37 ~]# grep Foreman::Cron /var/log/foreman/production.log
2025-12-19T02:10:20 [I|app|] Foreman::Cron[hourly]: running 1 task(s)
2025-12-19T02:10:20 [I|app|] Foreman::Cron[hourly]: starting ldap:refresh_usergroups
2025-12-19T02:10:20 [I|app|] Foreman::Cron[hourly]: finished ldap:refresh_usergroups
Member
There was a problem hiding this comment.
Using Logger.new($stdout) (or Logger.new($stderr) - but I think stdout is right) instead works:
[root@ip-10-0-167-37 ~]# foreman-rake cron:hourly
W, [2025-12-19T02:22:16.740554 #202577] WARN -- : Scoped order is ignored, it's forced to be batch order.
W, [2025-12-19T02:22:17.077076 #202577] WARN -- : Scoped order is ignored, it's forced to be batch order.
W, [2025-12-19T02:22:17.298995 #202577] WARN -- : Scoped order is ignored, it's forced to be batch order.
W, [2025-12-19T02:22:17.361471 #202577] WARN -- : Scoped order is ignored, it's forced to be batch order.
W, [2025-12-19T02:22:17.582867 #202577] WARN -- : Scoped order is ignored, it's forced to be batch order.
W, [2025-12-19T02:22:17.837891 #202577] WARN -- : Scoped order is ignored, it's forced to be batch order.
I, [2025-12-19T02:22:18.655119 #202577] INFO -- : Foreman::Cron[hourly]: running 1 task(s)
I, [2025-12-19T02:22:18.655201 #202577] INFO -- : Foreman::Cron[hourly]: starting ldap:refresh_usergroups
I, [2025-12-19T02:22:18.658580 #202577] INFO -- : Foreman::Cron[hourly]: finished ldap:refresh_usergroups
evgeni
reviewed
Dec 19, 2025
| require 'foreman/cron' | ||
|
|
||
| # Register built-in recurring tasks for each cadence. | ||
| # Plugins can also call Foreman::Cron.register(:daily, 'my_plugin:task'). |
Member
There was a problem hiding this comment.
I think we should add this to https://github.com/theforeman/foreman/blob/develop/developer_docs/how_to_create_a_plugin.asciidoc
Also, where should they do this? I did that in the register_plugin initializer (in engine.rb of the plugin), and it worked, but is that the recommended place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
Foreman::Cronwith a hard-coded mapping fromhourly/daily/weekly/monthlyto existing rake tasks, and addcron:hourly,cron:daily,cron:weeklyandcron:monthlyrake tasks.These serve as generic entrypoints for scheduling (e.g. systemd timers in foremanctl) instead of wiring individual tasks.
Related to: theforeman/foremanctl#288 (review)