Fixes #38877 - Update donut chart wrapper to pf5 #10788
Open
+940
−708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlabaj
changed the title
kmalyjur
suggested changes
Dec 8, 2025
Contributor
kmalyjur
left a comment
kmalyjur
left a comment
There was a problem hiding this comment.
Thank you for the changes! I still have 2 proposals:
- Percentages now default to one decimal place (100.0%), could the default be without it (100%)?
- When the chart was clickable, the mouse pointer used to change. Could it be added again?
What do you think?
tlabaj
force-pushed
the
donut_chart
branch
3 times, most recently
from
2da74c6 to
387c6da
Compare
kmalyjur
suggested changes
Dec 15, 2025
pr-processor
bot
added
Waiting on contributor
Needs re-review
and removed
Needs re-review
labels
tlabaj
force-pushed
the
donut_chart
branch
2 times, most recently
from
88cea21 to
735f0b8
Compare
Contributor
|
Thank you, now it just needs to be verified |
kmalyjur
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 38877