[CP] Orchestration:Template fixes for 3.16-stable #10796
+145
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stejskalleos
commented
Dec 10, 2025
stejskalleos
commented
- d61cf5a - Return correct template kind without compute attrs
- 4e9798e - host_param macro & transient parameters
If `compute_attributes` are empty, we can still determine the template kind by examining the image that is attached to the host. (cherry picked from commit 4e9798e)
:host_param macro now allows rendering host parameters that are assigned to the host, but are not in the database. Background Transient (new) host parameters associated with the host are not rendered in the template check action nor in the 'Orchestration:Templates' queue. This behavior causes issues for image-based provisioning when the activation key is defined on the host level, rather than on the hostgroup. Fixed scenarios * 'host_param' macro now renders all host parameters * 'hosts#template_used' action now renders templates with all host parameters * 'Orchestration::Templates' now renders templates with all host parameters Links * Community RFC: https://community.theforeman.org/t/provisioning-hosts-doesnt-work-well-with-host-parameters/44334 * Original ticket: https://projects.theforeman.org/issues/38422 (cherry picked from commit d61cf5a)
pr-processor
bot
added
Not yet reviewed
Stable branch
Member
|
Please also open a PR for 3.17. |
Member
|
Will this need a packaging bump as well to make a new version for 3.16 and 3.17? |
Contributor
Author
AFAIK, no package changes (except for Foreman itself) are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.