Skip to content

Fixes #38944 - Fix facterdb tests #10799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evgeni merged 1 commit into from
Dec 15, 2025
+7 −0
Merged

Fixes #38944 - Fix facterdb tests #10799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/unit/puppet_fact_parser_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,13 @@ def get_facterdb_facts(facterversion, os_name, os_major)
require 'facterdb'
# This uses the legacy facts since it's always present
filter = "facterversion=/^#{Regexp.escape(facterversion)}\./ and operatingsystem=#{os_name} and operatingsystemmajrelease=#{os_major}"

# patch the facterdb_fact_files to return only the facts for the given OS and Facter version
# This prevents the facterDB from loading other files, that may contain incorrect JSON
facterdb_fact_files = FacterDB.facterdb_fact_files
cutom_files_list = facterdb_fact_files.select { |file| file =~ /\/#{Regexp.escape(facterversion)}\// && file.include?(os_name.downcase) && file.include?(os_major) }
FacterDB.expects(:facterdb_fact_files).returns(cutom_files_list)

result = FacterDB.get_facts(filter)
raise "No facts found for #{os_name} #{os_major} on Facter #{facterversion}" if result.empty?
result.first.dup
Expand Down
Loading