Fix BIOS facts parsing for RHSM registered hosts #10806
Open
+22
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use correct RHSM fact keys to populate BIOS details on host pages.
chris1984
approved these changes
Jan 9, 2026
Member
There was a problem hiding this comment.
Looks good and I can see the bios info on my dev box now. Thanks @nofaralfasi @ShimShtein can you review and green ack please if it looks good?
ekohl
reviewed
Jan 9, 2026
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Seeing as how we missed this, would it make sense to have more of an integration test like we have with Puppet and include a full JSON fixture taken from a VM that we can parse?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use correct RHSM fact keys to populate BIOS details on host pages.
Note: RM was not working at the time this PR was created. I will create the RM and attach it to this PR once the issue is resolved.
The BIOS card on the host details page was empty for hosts registered via subscription-manager because the RhsmFactParser was looking for BIOS facts using incorrect key names.
RHSM facts use dot separators (e.g., 'dmi.bios.vendor'), but the parser was incorrectly looking for double-colon separators with an 'all_records' prefix (e.g., 'dmi::bios::all_records::vendor'), which never matched.
This commit fixes the bios method to use the correct RHSM fact keys.
Also fixes the model method's virtual machine detection for consistency with the RHSM fact naming convention.
After this fix, hosts need to re-upload their facts (subscription-manager facts --update) for BIOS data to be populated.