Remove grub templates #10807
Merged
Remove grub templates #10807
+136
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvind4501
force-pushed
the
remove-old-grub-templates
branch
3 times, most recently
from
7b73190 to
ef0cd67
Compare
arvind4501
force-pushed
the
remove-old-grub-templates
branch
from
ef0cd67 to
6d88656
Compare
stejskalleos
approved these changes
Jan 5, 2026
Contributor
stejskalleos
left a comment
stejskalleos
left a comment
There was a problem hiding this comment.
🍏 LGTM
Test coverage is excellent and covers all scenarios, OS association, Host group association, removal of templates & the template kinds.
I'll merge when CI is done & green.
Contributor
|
Thanks @arvind4501 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a followup step on #10698 , which removed PXEGrub support.