Fixes #39593 - Restore background color for Rails-rendered pages - #11134
Open
sjha4 wants to merge 1 commit into
Open
Fixes #39593 - Restore background color for Rails-rendered pages#11134sjha4 wants to merge 1 commit into
sjha4 wants to merge 1 commit into
Conversation
pondrejk
approved these changes
Aug 6, 2026
Member
|
should the other |
Contributor
@MariaAga It is still needed for pages like |
Lukshio
previously approved these changes
Aug 6, 2026
Member
|
So can it be moved up to the body? like in |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@MariaAga Ya..It can be moved up to body..Updated.. |
Contributor
Author
|
Katello ruby test failure is an unrelated flakiness issue.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit fb3d37d ("Fixes #39276 - Add Stylelint rule to block global css overrides") changed the selector in layout.scss from .pf-v5-c-page to #foreman-page to comply with the new foreman/no-root-pf-overrides stylelint rule. This inadvertently dropped the --pf-v5-c-page--BackgroundColor override for #rails-app-content, which is the wrapper for Rails-rendered pages in base.html.erb and uses class="pf-v5-c-page" instead of id="foreman-page".
As a result, Rails-rendered pages (used by Foreman and plugins like Katello) no longer inherit the intended background color (--pf-v5-global--BackgroundColor--100).
Example:
Go to menu -> facts
See the background color difference in empty section.
Go to menu > Lifecycle > Content Views
Page renders with this background color: