-
Notifications
You must be signed in to change notification settings - Fork 114
Fixes #38335 - Adding Ansible Diff Mode to Ansible Job Templates #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
da9ff40 to
f396c83
Compare
|
Hi, it may take some time before we're able to start reviewing this PR. Thank you for your patience and understanding. |
|
docs triage: @nofaralfasi Can you please review this PR? |
| :check_mode => host.host_param('ansible_roles_check_mode'), | ||
| :job_check_mode => template_invocation.template.ansible_check_mode, | ||
| :job_diff_mode => template_invocation.template.ansible_diff_mode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just looking at the pattern here: don't we need to add Nervermind, I found it in another PR.diff_mode here as well?..
|
Hi @nofaralfasi , I see this PR is approved. Is there anything pending before this PR may be merged? |
Overview of Changes
This PR intends to add the Ansible Diff Mode (identified with the --diff argument to ansible-runner) to Ansible Job Templates via a checkbox option. This is a follow-on to the changes made to support Ansible Check Mode in https://projects.theforeman.org/issues/37942. Ansible Diff Mode reports changes Ansible tasks make only if the module supports Ansible Diff Mode. Otherwise, the task reports a change has been made with no further details. Note that when used in conjunction with Ansible Check Mode, tasks report changes they would have made without making those changes. Ansible Check Mode and Ansible Diff Mode are not dependent on one-another and can be run independently. Refer to https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_checkmode.html#using-diff-mode for more details about Ansible Diff Mode. See below screenshot for UI update:
Implementation Considerations
As suggested in #742, it would be beneficial to have this sort of capability at the job level. I may tackle that next.
Testing Steps
Checklists
Additional Notes
This PR is not dependent on any other changes. The follow PRs are dependent on this change: