Fixes #37418 - Mask hidden Ansible variable values in UI #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidden Ansible variables were displayed in plain text on the host details page under both the Variables and Inventory tabs. This change masks hidden variable values with '*****' in the UI while still allowing the actual values to be visible when editing (which requires edit_ansible_variables permission).
Contributor
Author
|
The failing tests are unrelated to this PR. |
cboygwj-web
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of Changes
Hidden Ansible variables were displayed in plain text on the host details page under both the Variables and Inventory tabs.
Implementation Considerations
This change masks hidden variable values with '*****' in the UI while still allowing the actual values to be visible when editing (which requires edit_ansible_variables permission).
Testing Steps
Described in the RM issue: https://projects.theforeman.org/issues/37418
Checklists