Fix corrupted_roles check: remove reference to missing 'override' column #1064
+7
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
The CheckCorruptedRoles checks fails to run on latest Foreman. It attempts to select and insert into
filters.overrideorfirst.override. This column has been removed from the database schema in theforeman/foreman#10370, but not sure why it started to fail in our tests now.Solution
Removed all references to the
overridecolumn in the SQL queries (both the selection logic and the record creation logic).Testing