Skip to content

Fixes #38603 - replace react-ellipsis-with-tooltip #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofedoren merged 1 commit into from
Jul 22, 2025
+2 −2
Merged

Fixes #38603 - replace react-ellipsis-with-tooltip #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions webpack/components/TemplateSyncResult/components/SyncedTemplate/StringInfoItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import EllipsisWithTooltip from 'react-ellipsis-with-tooltip';
import { Truncate } from '@patternfly/react-core';
import PropTypes from 'prop-types';

import InfoItem from './InfoItem';
Expand All @@ -8,7 +8,7 @@ import { itemIteratorId } from './helpers';
const StringInfoItem = ({ template, attr, tooltipText, mapAttr, elipsed }) => {
const inner = <span>{mapAttr(template, attr)}</span>;
const innerContent = elipsed ? (
<EllipsisWithTooltip placement="top">{inner}</EllipsisWithTooltip>
<Truncate content={inner} tooltipPosition="top" />
Copy link
Member

@ofedoren ofedoren Jul 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question: why tooltipPosition is top instead of auto? BTW, Patternfly docs state that top is the default value anyway.

UPD: Nevermind me, it was top before.

) : (
inner
);
Expand Down