Skip to content

Fixes #37692 - Add firmware option for Libvirt hosts creation #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofedoren merged 1 commit into from
Nov 26, 2024
+6 −2
Merged

Fixes #37692 - Add firmware option for Libvirt hosts creation #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/host_create.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ Available keys for `--compute-attributes`:
cpus # number of CPUs
memory # string, amount of memory, value in bytes
start # Must be a 1 or 0, whether to start the machine or not
firmware # automatic/bios/uefi/uefi_secure_boot (UEFI with Secure Boot enabled)
```

Available keys for `--interface`:
Expand Down
7 changes: 5 additions & 2 deletions lib/hammer_cli_foreman/compute_resource/libvirt.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ def compute_attributes
[
['cpus', _('Number of CPUs'), { bold: true }],
['memory', _('String, amount of memory, value in bytes'), { bold: true }],
['boot_order', _('Device names to specify the boot order')]
['boot_order', _('Device names to specify the boot order')],
['firmware', _('automatic/bios/uefi/uefi_secure_boot (UEFI with Secure Boot enabled)')]
]
end

Expand Down Expand Up @@ -49,7 +50,9 @@ def provider_vm_specific_fields
Fields::Field.new(:label => _('OS Type'), :path => [:os_type]),
Fields::Field.new(:label => _('Domain Type'), :path => [:domain_type]),
Fields::Field.new(:label => _('Persistent'), :path => [:persistent]),
Fields::List.new(:label => _('Boot order'), :path => [:boot_order])
Fields::List.new(:label => _('Boot order'), :path => [:boot_order]),
Fields::Field.new(:label => _('Firmware'), :path => [:firmware]),
Fields::Field.new(:label => _('Secure Boot'), :path => [:secure_boot])
]
end

Expand Down