Refs #38124 - Add correct description for invalidating multiple users jwt

[girijaasoni]

No description provided.

[ofedoren]

Do we really need this? On latest hammer-cli and hammer-cli-foreman I get:

UPD: We could rather treat this PR for #636 (comment)

[girijaasoni]

Do we really need this?

Yes, because when passing the search params from CLI, we don't need to URL encode the search query. We need to do that only when using curl command

I can add tests too in a new ref PR

[ofedoren]

Yes, because when passing the search params from CLI, we don't need to URL encode the search query. We need to do that only when using curl command

I'd say we can then remove URL-encoded from API description as well. curl can be used in a more user friendly way without a need to encode anything: curl -u user:password -H 'Content-Type:application/json' -X DELETE https://foreman.ofedoren.com/api/v2/registration_tokens -d '{ "search": "id ^ (5)" }'

I can add tests too in a new ref PR

👍

[girijaasoni]

without a need to encode anything: curl -u user:password -H 'Content-Type:application/json' -X DELETE https://foreman.ofedoren.com/api/v2/registration_tokens -d '{ "search": "id ^ (5)" }'

We are sending search params as a part of url parameters. We need to URL encode it there
it is something like curl --user user:password -X DELETE http://localhost:3000/api/registration_tokens?search=id%20%5E%20%281%2C2%2C3%29 -H 'Content-Type: application/json

[ofedoren]

We are sending search params as a part of url parameters. We need to URL encode it there it is something like curl --user user:password -X DELETE http://localhost:3000/api/registration_tokens?search=id%20%5E%20%281%2C2%2C3%29 -H 'Content-Type: application/json

Who are we and why do we do that? I mean, the API can be used that way, sure. But that's just a curl example, which can accept both ways (your and mine) to pass the parameters. Most tools/libs will just do that for you.

Wording URL-encoded even in API is kinda misleading since it forces one of the variants. Moreover, we don't do that for other search string params:

[girijaasoni]

We are sending search params as a part of url parameters. We need to URL encode it there it is something like curl --user user:password -X DELETE http://localhost:3000/api/registration_tokens?search=id%20%5E%20%281%2C2%2C3%29 -H 'Content-Type: application/json

Who are we and why do we do that? I mean, the API can be used that way, sure. But that's just a curl example, which can accept both ways (your and mine) to pass the parameters. Most tools/libs will just do that for you.

@ShimShtein , what do you think about this?

[girijaasoni]

converting this PR to draft. will be using it later for adding hammer tests.