drop libexec wrappers, nobody uses them anymore #2042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
evgeni
commented
Jun 24, 2025
|
|
||
| # Created by pyp2rpm-3.3.3 | ||
| %global pypi_name pulpcore | ||
| %global wrappers gunicorn pulpcore-worker pulp-content pulpcore-manager |
Member
Author
There was a problem hiding this comment.
gunicornunused since theforeman/puppet-pulpcore@7e12c0fpulpcore-workerunused since Use pulpcore-worker entrypoint directly, without a wrapper puppet-pulpcore#383- I can't find any reference that we ever used the
pulp-content(we usedgunicorndirectly until the switch to 3.39) orpulpcore-manager(https://github.com/theforeman/puppet-pulpcore/blob/master/manifests/admin.pp never hadlibexecin it's$PATH) wrappers
Member
|
Last time that I tried to cleanup libexec wrappers it failed. Let's see how this goes. |
Member
Author
|
Do you recall what failed? |
Member
Author
|
as this is only targeting |
Member
Author
|
@Odilhao so, shall we try this? |
Odilhao
approved these changes
Jul 15, 2025
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.