use dashes, not underscores when settings HTTP headers #1214
Conversation
underscores are not allowed in HTTP headers and some backends reject headers using underscores before converting incoming dashes to underscores to pass to the app
| 'set SSL_CLIENT_S_DN "%{SSL_CLIENT_S_DN}s"', | ||
| 'set SSL_CLIENT_CERT "%{SSL_CLIENT_CERT}s"', | ||
| 'set SSL_CLIENT_VERIFY "%{SSL_CLIENT_VERIFY}s"', | ||
| 'set X-FORWARDED-PROTO "https"', |
There was a problem hiding this comment.
There was a problem hiding this comment.
No, it will make it work!
My-Cool-Header gets translated to HTTP_MY_COOL_HEADER by gunicorn. It's just in the past it also allowed My_Cool_Header to become HTTP_MY_COOL_HEADER (you remember, huh?) and this used to work for us, and now it doesn't anymore.
There was a problem hiding this comment.
Also, puppet-pulpcore should really not depend on puppet-foreman setting things up -- it can be deployed standalone after all :)
There was a problem hiding this comment.
Ok, but I don't see us setting it in puppet-pulpcore nor puppet-foreman_proxy_content so on content proxies it's actually broken as well. Just in a different way.
There was a problem hiding this comment.
I see you came to the same conclusion.
There was a problem hiding this comment.
underscores are not allowed in HTTP headers and some backends reject
headers using underscores before converting incoming dashes to
underscores to pass to the app