Set client_endpoint on container_gateway plugin #517
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianballou
reviewed
Apr 8, 2025
Contributor
ianballou
left a comment
ianballou
left a comment
There was a problem hiding this comment.
Patching in this change specifically causes an error for the installer:
[root@centos9-proxy-devel foreman_proxy_content]# foreman-installer --full-help
/usr/share/gems/gems/kafo-7.6.0/lib/kafo/puppet_module.rb:70:in `parse': No Puppet module parser is installed and no cache of the file /usr/share/foreman-installer/modules/foreman_proxy_content/manifests/init.pp is available. Please check debug logs and install optional dependencies for the parser. (Kafo::ParserError)
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/configuration.rb:133:in `block in modules'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/configuration.rb:133:in `map'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/configuration.rb:133:in `modules'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/kafo_configure.rb:262:in `modules'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/kafo_configure.rb:266:in `module'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/hook_context.rb:113:in `module_present?'
from /usr/share/foreman-installer/hooks/boot/20-certs_update.rb:2:in `block (4 levels) in load'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/hooking.rb:36:in `instance_eval'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/hooking.rb:36:in `block (4 levels) in load'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/hook_context.rb:19:in `instance_eval'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/hook_context.rb:19:in `execute'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/hooking.rb:67:in `block in execute'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/hooking.rb:65:in `each'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/hooking.rb:65:in `execute'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/kafo_configure.rb:144:in `initialize'
from /usr/share/gems/gems/clamp-1.3.2/lib/clamp/command.rb:140:in `new'
from /usr/share/gems/gems/clamp-1.3.2/lib/clamp/command.rb:140:in `run'
from /usr/share/gems/gems/kafo-7.6.0/lib/kafo/kafo_configure.rb:54:in `run'
from /sbin/foreman-installer:8:in `<main>'
No error is caused by theforeman/puppet-foreman_proxy#863, however.
Signed-off-by: Eric D. Helms <[email protected]>
ehelms
force-pushed
the
set-client-endpoint
branch
from
8dcdbde to
5d6c760
Compare
Member
Author
When you patch a puppet module in production you have to install the puppet-strings gem: |
ianballou
approved these changes
Apr 9, 2025
Contributor
ianballou
left a comment
ianballou
left a comment
There was a problem hiding this comment.
I wasn't able to do a full test on my proxy since the CNAME wasn't set up right for the installer, but looking at the use of client_facing_servername, this appears correct to me.
evgeni
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires theforeman/puppet-foreman_proxy#863