Skip to content

Conversation

@ehelms
Copy link
Member

@ehelms ehelms commented Sep 24, 2025

No description provided.

@ehelms ehelms force-pushed the ensure-services-removed branch from ffde2c3 to 03e6436 Compare September 24, 2025 20:44
#
# $register_as_smartproxy:: Whether to register as a smart proxy
#
# $enable_vulnerability:: Enable vulnerability services
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a value to keep this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has proven to mostly cause confusion in the context of the installer as I added it to have more granular control but not intended to be user facing; however, as noted it presents itself that way and leads to confusion.

@ehelms ehelms force-pushed the ensure-services-removed branch 2 times, most recently from 3c3da76 to e09a0b8 Compare September 25, 2025 13:10
@ehelms
Copy link
Member Author

ehelms commented Sep 25, 2025

There are two elements that cannot be removed right now:

  • Volumes
  • Network

This is largely due to the relationships and requirements on those by each of the services.

@ehelms ehelms force-pushed the ensure-services-removed branch from e09a0b8 to 5284e1a Compare September 25, 2025 14:03
# $remediations_database_password:: Database password for remediations service
#
class iop (
Enum['present', 'absent'] $ensure = 'present',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely the former, and probably the latter. Right now this change does not remove the network or volumes as those are proving hard to remove due to dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehelms ehelms force-pushed the ensure-services-removed branch from 5284e1a to eaee9d0 Compare September 26, 2025 13:01
@evgeni
Copy link
Member

evgeni commented Sep 29, 2025

There are two elements that cannot be removed right now:

  • Volumes
  • Network

This is largely due to the relationships and requirements on those by each of the services.

Maybe a stupid idea, but can we drop the require of the individual containers on their Volumes and Networks and then do smth like

if ($ensure == 'present') {
  Podman::Network <| tag == 'iop' |> ~> Podman::Quadlet <| tag == 'iop' |>
  Podman::Volume <| tag == 'iop' |> ~> Podman::Quadlet <| tag == 'iop' |>
} else {
  Podman::Quadlet <| tag == 'iop' |> -> Podman::Network <| tag == 'iop' |>
  Podman::Quadlet <| tag == 'iop' |> -> Podman::Volume <| tag == 'iop' |>
}

Maybe even -> instead of ~> and add a subscribe? No, wait, subscribe also enforces ordering. Stupid.

@evgeni evgeni merged commit c086f77 into master Sep 29, 2025
9 checks passed
@ekohl ekohl deleted the ensure-services-removed branch September 29, 2025 12:56
@ekohl
Copy link
Member

ekohl commented Sep 29, 2025

There's some merit in not destroying the volume so users can easily switch back and forth, but I'd agree with the network part.

@evgeni
Copy link
Member

evgeni commented Sep 29, 2025

I think the relevant data is in postgres, so it won't be too bad, but I see the point

@evgeni
Copy link
Member

evgeni commented Sep 29, 2025

There are two elements that cannot be removed right now:

  • Volumes
  • Network

This is largely due to the relationships and requirements on those by each of the services.

Maybe a stupid idea, but can we drop the require of the individual containers on their Volumes and Networks and then do smth like

if ($ensure == 'present') {
  Podman::Network <| tag == 'iop' |> ~> Podman::Quadlet <| tag == 'iop' |>
  Podman::Volume <| tag == 'iop' |> ~> Podman::Quadlet <| tag == 'iop' |>
} else {
  Podman::Quadlet <| tag == 'iop' |> -> Podman::Network <| tag == 'iop' |>
  Podman::Quadlet <| tag == 'iop' |> -> Podman::Volume <| tag == 'iop' |>
}

Maybe even -> instead of ~> and add a subscribe? No, wait, subscribe also enforces ordering. Stupid.

So I tried this with networks in #74

@evgeni evgeni added the enhancement New feature or request label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants