-
Notifications
You must be signed in to change notification settings - Fork 6
Add parameter to ensure all services absent #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ffde2c3 to
03e6436
Compare
| # | ||
| # $register_as_smartproxy:: Whether to register as a smart proxy | ||
| # | ||
| # $enable_vulnerability:: Enable vulnerability services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there a value to keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has proven to mostly cause confusion in the context of the installer as I added it to have more granular control but not intended to be user facing; however, as noted it presents itself that way and leads to confusion.
3c3da76 to
e09a0b8
Compare
|
There are two elements that cannot be removed right now:
This is largely due to the relationships and requirements on those by each of the services. |
e09a0b8 to
5284e1a
Compare
Signed-off-by: Eric D. Helms <[email protected]>
| # $remediations_database_password:: Database password for remediations service | ||
| # | ||
| class iop ( | ||
| Enum['present', 'absent'] $ensure = 'present', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely the former, and probably the latter. Right now this change does not remove the network or volumes as those are proving hard to remove due to dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5284e1a to
eaee9d0
Compare
Maybe a stupid idea, but can we drop the if ($ensure == 'present') {
Podman::Network <| tag == 'iop' |> ~> Podman::Quadlet <| tag == 'iop' |>
Podman::Volume <| tag == 'iop' |> ~> Podman::Quadlet <| tag == 'iop' |>
} else {
Podman::Quadlet <| tag == 'iop' |> -> Podman::Network <| tag == 'iop' |>
Podman::Quadlet <| tag == 'iop' |> -> Podman::Volume <| tag == 'iop' |>
}Maybe even |
|
There's some merit in not destroying the volume so users can easily switch back and forth, but I'd agree with the network part. |
|
I think the relevant data is in postgres, so it won't be too bad, but I see the point |
So I tried this with networks in #74 |
No description provided.