Fix iop_frontend trying to pull image with ensure absent #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Related is southalc/podman#119 to ensure true idempotency. |
evgeni
reviewed
Oct 1, 2025
|
|
||
| in_sync = current_checksum == desired_checksum | ||
| Puppet.debug("Current checksum: #{current_checksum}, Desired checksum: #{desired_checksum}. In sync: #{in_sync}") | ||
| File.exist?(File.join(resource[:destination], '.iop_frontend_checksum')) |
Member
There was a problem hiding this comment.
I've been starring at this, thinking "but this breaks updates", but it doesn't because you define a insync? below, that ensures the checksum again?
evgeni
approved these changes
Oct 1, 2025
Member
Author
|
The tests will pass once southalc/podman#119 is merged. This change, and behaviour unconvered that failure in puppet-podman design. |
Signed-off-by: Eric D. Helms <[email protected]>
ehelms
force-pushed
the
fix-iop-frontend
branch
from
fc231b0 to
51e64fd
Compare
evgeni
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.