Enable new cops by default & fix many cops #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
reviewed
Sep 26, 2023
|
|
||
| def underscore(src) | ||
| src = src.gsub(/::/, '/') | ||
| src = src.gsub("::", '/') |
Member
There was a problem hiding this comment.
would '::' also work? (I would have expected 👮 to yell at you)
Member
Author
There was a problem hiding this comment.
In this repo that cop is disabled. I'm not sure why RuboCop would prefer ".
Member
There was a problem hiding this comment.
Ah, very well, then something for the future.
evgeni
reviewed
Sep 26, 2023
bin/smart-proxy-dhcp-isc
Outdated
| @@ -0,0 +1,23 @@ | |||
| #!/usr/bin/env ruby | |||
Member
There was a problem hiding this comment.
why was this file added and how does it fix the Style/RedundantConstantBase cop?
not that I mind adding it, just puzzled how it fits into this PR
Member
Author
There was a problem hiding this comment.
The wonders of git add with some local file that you didn't intend to.
This pleases RuboCop
ekohl
force-pushed
the
rubocop-update
branch
from
16d3677 to
a6bdde6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.