Fixes #38498 - Fix incorrect Cycle power operation in Redfish provider #919
+87
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroshi-ikuta
force-pushed
the
feature/redfish_powercycle
branch
2 times, most recently
from
79dad3c to
16898b1
Compare
hiroshi-ikuta
force-pushed
the
feature/redfish_powercycle
branch
from
16898b1 to
28c05bf
Compare
stejskalleos
requested changes
Sep 12, 2025
Contributor
stejskalleos
left a comment
stejskalleos
left a comment
There was a problem hiding this comment.
🍏 Tested with Redfish-Mockup-Server, and it seems to be working.
curl --user admin:changeme -X PUT -H "Content-Type: application/json" -d '{}' "http://localhost:8080/bmc/localhost:8000/chassis/power/cycle"Red fish server log:
POST: Content: type=application/json and params={}
POST: Data: {'ResetType': 'PowerCycle'}
127.0.0.1 - - [12/Sep/2025 09:01:03] "POST /redfish/v1/Systems/BladeServer-1/Actions/ComputerSystem.Reset HTTP/1.1" 204 -
A few comments regarding unused code, otherwise LGTM.
Bug #38498 mentions 3 power operation bugs in Redfish provider. This PR fixes wrong implementation of Cycle power operatoin: When user pushes Cycle button, Redfish provider does ForceRestart instead of PowerCycle. This PR makes powercycle method does 'PowerCycle'. Co-Authored-By: Vanou Ishii <[email protected]>, Yusuke Hirota <[email protected]>
hiroshi-ikuta
force-pushed
the
feature/redfish_powercycle
branch
from
28c05bf to
5868250
Compare
stejskalleos
approved these changes
Sep 16, 2025
Contributor
stejskalleos
left a comment
stejskalleos
left a comment
There was a problem hiding this comment.
🍏 LGTM
Works as expected
Contributor
|
Thank you, @hiroshi-ikuta and @vanou, for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #38498 mentions 3 power operation bugs in Redfish provider. This PR fixes wrong implementation of Cycle power operatoin: When user pushes Cycle button, Redfish provider does ForceRestart instead of PowerCycle.
Modifications in this PR
Fix incorrect "Cycle" power operation implementation in Redfish provider
The powercycle method defined in
modules/bmc/redfish.rbof smart-proxy does 'ForceRestart' instead of 'PowerCycle'. This PR makes powercycle method does 'PowerCycle'.