Skip to content

Conversation

@adamruzicka
Copy link
Contributor

No description provided.

Copy link
Contributor

@adamlazik1 adamlazik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Side note: looking at the failed tests with ruby 2.7.8, shouldn't we remove that testing scenario completely if ruby 3.0 is required for smart_proxy?

@adamruzicka
Copy link
Contributor Author

Side note: looking at the failed tests with ruby 2.7.8, shouldn't we remove that testing scenario completely if ruby 3.0 is required for smart_proxy?

Yeah, opened #107 for that

@adamlazik1 adamlazik1 merged commit 9634a4c into theforeman:master Dec 19, 2025
8 of 11 checks passed
@adamlazik1
Copy link
Contributor

Thanks @adamruzicka!

@adamruzicka adamruzicka deleted the unpin-rex branch December 19, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants