Skip to content

Conversation

@ekohl
Copy link
Member

@ekohl ekohl commented Jul 9, 2021

Currently the example config file contains enabled: true which means yum install is sufficient to enable it. However, you must also create a key. All plugins are disabled by default and this follow that.

What's worse, true means both HTTP and HTTPS which can also be less secure.

Currently the example config file contains enabled: true which means yum
install is sufficient to enable it. However, you must also create a key.
All plugins are disabled by default and this follow that.

What's worse, true means both HTTP and HTTPS which can also be less
secure.
@ekohl
Copy link
Member Author

ekohl commented Jul 9, 2021

Ok, maybe it was wrong fro my side:

$ grep enabled: smart_proxy_*/settings.d/*.*
smart_proxy_ansible/settings.d/ansible.yml.example::enabled: true
smart_proxy_container_gateway/settings.d/container_gateway.yml.example::enabled: true
smart_proxy_dynflow/settings.d/dynflow.yml.example::enabled: true
smart_proxy_host_reports/settings.d/host_reports.yml.example::enabled: true
smart_proxy_ipam/settings.d/externalipam.yml.example::enabled: true
smart_proxy_monitoring/settings.d/monitoring_icinga2.yml.example::enabled: true
smart_proxy_monitoring/settings.d/monitoring_icingadirector.yml.example::enabled: true
smart_proxy_monitoring/settings.d/monitoring.yml.example::enabled: true
smart_proxy_omaha/settings.d/omaha.yml.example::enabled: true
smart_proxy_openscap/settings.d/openscap.yml.example::enabled: true
smart_proxy_pulp/settings.d/pulpcore.yml.example::enabled: true
smart_proxy_remote_execution_ssh/settings.d/remote_execution_ssh.yml.example::enabled: false
smart_proxy_salt/settings.d/salt.yml.example::enabled: true
smart_proxy_shellhooks/settings.d/shellhooks.yml.example:#:enabled: https
smart_proxy_shellhooks/settings.d/shellhooks.yml.example::enabled: false
smart_proxy_vault/settings.d/vault.yml.example::enabled: true

@ehelms
Copy link
Member

ehelms commented Jul 16, 2021

@adamruzicka What do you want to do here? Make this change or keep it the way it seems most plugins are?

@adamruzicka
Copy link
Contributor

I'd like to stay consistent with other plugins

@ekohl
Copy link
Member Author

ekohl commented Jul 16, 2021

Given most actually default to true, I'm closing this. Let's finish up #57 so it at least fails fast when it's not configured.

@ekohl ekohl closed this Jul 16, 2021
@ekohl ekohl deleted the 32971-do-not-enable-by-default branch July 16, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants