-
Notifications
You must be signed in to change notification settings - Fork 0
jayden/basic-query-implement #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
BayernMuller
wants to merge
9
commits into
team/query-with-index
Choose a base branch
from
jayden/basic-query-implement
base: team/query-with-index
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to improve uniqueness and performance
…TagNode for improved performance and uniqueness
…proved type safety and performance
…ordered_map for enhanced data structure operations
…es for improved readability and maintainability
… use type aliases for improved clarity and consistency
…thods in DOMQuery for enhanced querying capabilities
Jin-uu
reviewed
Dec 29, 2025
Comment on lines
+26
to
+30
| for (const auto& candidate : candidates) { | ||
| if (matchAllConditions(candidate, options)) { | ||
| return DOMQuery(*candidate, dom_indexer_); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
searchCandidatesFromIndexer에서 이미 전체 Dom에 대해 모든 option들에 대한 쿼리를 진행 했는데, 여기서 다시 모든 option에 대한 검사를 중복해서 수행하는게 비효율적으로 보임.
searchCandidatesFromIndexer에서 각 option에 대해 한 번에 할 수 있어보임.
e.g.,
tag쿼리 결과NodeList생성- 1번 결과에서
class에 대한 쿼리 진행 (Dom 전체가 아닌 이전 결과NodeList에서 걸러내기) - ... 이후 반복
코드가 더러울거 같긴 한데, 조금 다듬어 보면 괜찮게 나올지도?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement basic query functionality with cardinality-based index selection
Changes
Key Features
TODO
불안한 점