Skip to content

[chore] 컨벤션 정비 - #74

Merged
yeondon125 merged 3 commits into
developfrom
chore/update-conventions-and-deps
Jun 25, 2026
Merged

yeondon125 merged 3 commits into
developfrom
chore/update-conventions-and-deps

Conversation

@junjuny0227

Copy link
Copy Markdown
Member

개요 💡

코드 컨벤션 정비 작업입니다. 의존성 업그레이드, Zod 스키마 네이밍 통일, 코드 컨벤션 문서 개편을 함께 진행했습니다.

작업내용 ⌨️

  • 의존성 업그레이드: pnpm 10.30.3 → 11.8.0, zod/@tanstack/react-query/axios/react-hook-form/tailwindcss 등 마이너 버전 업그레이드 및 pnpm-workspace.yaml 추가
  • 스키마 리팩토링: project-form의 Zod 스키마 변수명을 PascalCase로 통일 (projectRegistrationSchema → ProjectRegistrationSchema 등)
  • 문서 개편: CodeConvention.md의 FSD 구조 설명 및 네이밍 규칙 표를 현재 프로젝트 구조에 맞게 갱신

리뷰 요청사항 👀

  • 의존성 마이너 업그레이드 후 빌드/린트 통과 여부 확인 부탁드립니다.

검증

  • pnpm format:check
  • pnpm lint
  • pnpm build

@vercel

vercel Bot commented Jun 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
every-gsm-client-v2 Ready Ready Preview, Comment Jun 21, 2026 11:55pm

Request Review

@junjuny0227 junjuny0227 self-assigned this Jun 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's code conventions documentation to align with Feature-Sliced Design (FSD) and refactors the schemas in src/features/project-form to PascalCase accordingly. It also upgrades several dependencies in package.json and configures pnpm-workspace.yaml. Regarding the review feedback, a critical bug was identified in the Zod schema where z.file() is used; since this is not a valid Zod method, it will cause a runtime error and should be replaced with z.instanceof(File).

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@yeondon125 yeondon125 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

@s2yeons s2yeons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

머지하셔도 될 것 같습니다!

@yeondon125
yeondon125 merged commit eb6914e into develop Jun 25, 2026
3 checks passed

This branch was successfully deployed

1 active deployment
Preview — 9fce5699 Deployed Jun 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants