Repository navigation
[chore] 컨벤션 정비 - #74
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request updates the project's code conventions documentation to align with Feature-Sliced Design (FSD) and refactors the schemas in src/features/project-form to PascalCase accordingly. It also upgrades several dependencies in package.json and configures pnpm-workspace.yaml. Regarding the review feedback, a critical bug was identified in the Zod schema where z.file() is used; since this is not a valid Zod method, it will cause a runtime error and should be replaced with z.instanceof(File).
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
개요 💡
코드 컨벤션 정비 작업입니다. 의존성 업그레이드, Zod 스키마 네이밍 통일, 코드 컨벤션 문서 개편을 함께 진행했습니다.
작업내용 ⌨️
pnpm10.30.3 → 11.8.0,zod/@tanstack/react-query/axios/react-hook-form/tailwindcss등 마이너 버전 업그레이드 및pnpm-workspace.yaml추가project-form의 Zod 스키마 변수명을 PascalCase로 통일 (projectRegistrationSchema→ProjectRegistrationSchema등)CodeConvention.md의 FSD 구조 설명 및 네이밍 규칙 표를 현재 프로젝트 구조에 맞게 갱신리뷰 요청사항 👀
검증
pnpm format:checkpnpm lintpnpm build