Skip to content

Conversation

@themuffinator
Copy link
Owner

Summary

  • extend SoundSystem to own backend selection, activation, registration, and painted-time state
  • update sound initialization/shutdown and helper routines to call the new SoundSystem APIs instead of global variables
  • adjust OpenAL, DMA, and OGG backends to query SoundSystem for state and access the current backend interface

Testing

  • ninja -C build (fails: build.ninja missing)

https://chatgpt.com/codex/tasks/task_e_69076c83eee083288befedc2d41e0946

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1143 to 1144
soundSystem.BuildSoundList(sounds);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Declare soundSystem inside AL_AddLoopSounds

The new OpenAL helper AL_AddLoopSounds now calls soundSystem.BuildSoundList and soundSystem.SfxForHandle, but the function never defines a soundSystem reference or variable in its scope. There is no file‑scope soundSystem either, so this code will not compile (soundSystem is undefined). Add SoundSystem &soundSystem = S_GetSoundSystem(); at the start of this function before using it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants