Skip to content

Conversation

@themuffinator
Copy link
Owner

Summary

  • introduce a CRT post-processing module with user-facing controls and uniform updates
  • integrate the CRT flag into the bloom, depth-of-field, and fallback post-process paths
  • extend the GLSL generator with CRT-Lottes shader code and supporting uniforms

Testing

  • not run (no build directory)

https://chatgpt.com/codex/tasks/task_e_6907ce6bf0f8832686627eb55c4dc1a8

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

WORR/src/refresh/shader.cpp

Lines 760 to 766 in 54cdd42

if (bits & GLS_SKY_MASK)
GLSL(in vec3 v_dir;)
else
GLSL(in vec2 v_tc;)
if (bits & GLS_LIGHTMAP_ENABLE) {

P1 Badge Increase shader buffer size for new CRT GLSL

The CRT post‑processing block adds roughly two hundred GLSL(...) lines to the fragment shader, but the generator still builds the source into the fixed 4 KB buffer created in create_and_use_program. When GLS_CRT is set this block alone exceeds that capacity, so shader_printf will hit its Q_assert or silently truncate the shader before compilation. The CRT shader will fail to link reliably unless MAX_SHADER_CHARS (and the associated buffer) are enlarged or made dynamic.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants