Skip to content

Conversation

@themuffinator
Copy link
Owner

Summary

  • add bloom tuning cvars and keep documentation in sync
  • update bloom renderer to drive new controls and handle color correction fallbacks
  • integrate ACES-based color correction in shaders and post-process pipeline

Testing

  • not run (not requested)

https://chatgpt.com/codex/tasks/task_e_6907cd7df88c8326986a1a841de895b4

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

WORR/src/refresh/main.cpp

Lines 965 to 972 in 54c6ea6

if (gl_clear->integer) {
if (flags & PP_BLOOM) {
static const GLenum buffers[2] = { GL_COLOR_ATTACHMENT0, GL_COLOR_ATTACHMENT1 };
static const vec4_t black = { 0, 0, 0, 1 };
qglDrawBuffers(2, buffers);
qglClearBufferfv(GL_COLOR, 0, gl_static.clearcolor);
qglClearBufferfv(GL_COLOR, 1, black);
qglDrawBuffers(1, buffers);

P1 Badge Guard bloom clear when only color correction is active

When color correction is enabled with r_bloom disabled, GL_BindFramebuffer still sets the PP_BLOOM flag and enters the two-attachment clear path, but GL_InitFramebuffers allocates a second color attachment only when r_bloom is non‑zero. With only one attachment bound, the glDrawBuffers(2, …) and glClearBufferfv(GL_COLOR, 1, …) calls will target a non-existent buffer, triggering GL_INVALID_OPERATION and skipping the clear. The first frame after enabling color correction with gl_clear 1 will therefore render with undefined contents and log GL errors. The clear logic should either skip attachment 1 when bloom is disabled or allocate the secondary attachment whenever color correction forces PP_BLOOM.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants