Replace php-http/message-factory to psr/http-factory, HttpClientDiscovery to Psr18ClientDiscovery, MessageFactoryDiscovery to Psr17FactoryDiscovery and Http\Client\HttpClient to Psr\Http\Client\ClientInterface #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaboPT
changed the title
added 2 commits
April 15, 2024 14:23
…ctoryDiscovery to Psr17FactoryDiscovery and Http\Client\HttpClient to Psr\Http\Client\ClientInterface
FaboPT
changed the title
This was referenced Apr 15, 2024
|
@barryvdh Can you give an estimate for review that, please ? |
barryvdh
reviewed
Apr 30, 2024
| ) { | ||
| $request = $this->requestFactory->createRequest($method, $uri, $headers, $body, $protocolVersion); | ||
| $request = $this->requestFactory->createRequest($method, $uri); |
There was a problem hiding this comment.
This is a breaking change. Can we not set the headers/body/protocol on the request before sending?
| array $headers = [], | ||
| $body = null, | ||
| $protocolVersion = '1.1' | ||
| $uri |
There was a problem hiding this comment.
This is also a breaking change
| */ | ||
| private $requestFactory; | ||
|
|
||
| public function __construct($httpClient = null, RequestFactory $requestFactory = null) | ||
| public function __construct($httpClient = null, RequestFactoryInterface $requestFactory = null) |
There was a problem hiding this comment.
So these are different interfaces, which would require significant BC break.
|
@barryvdh So it sounds like a new major version is required? Is there any reason not to do one? I know these things are just interfaces so not like a security risk, but folks auditing my dependencies don't know that. It'd be good to get this fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.