Do not treat an empty card as a provided card #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis issue seems larger than this PR |
eileenmcnaughton
added a commit
to eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor
that referenced
this pull request
Jan 10, 2021
Hopefully thephpleague/omnipay-sagepay#158 will be merged but for now SagePay assumes that an empty card is an ignore-everything-else-card
|
Note that by contrast Paypal Rest create card request actually requires an object - even when empty - https://github.com/thephpleague/omnipay-paypal/blob/master/src/Message/RestCreateCardRequest.php so it's hard to support both without this |
eileenmcnaughton
added a commit
to eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor
that referenced
this pull request
Jan 10, 2021
Hopefully thephpleague/omnipay-sagepay#158 will be merged but for now SagePay assumes that an empty card is an ignore-everything-else-card Also declare support sagepay alternate function choices per thephpleague/omnipay-sagepay#157
eileenmcnaughton
added a commit
to eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor
that referenced
this pull request
Jan 10, 2021
Hopefully thephpleague/omnipay-sagepay#158 will be merged but for now SagePay assumes that an empty card should be filtered out
eileenmcnaughton
added a commit
to eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor
that referenced
this pull request
Jan 10, 2021
Hopefully thephpleague/omnipay-sagepay#158 will be merged but for now SagePay assumes that an empty card should be filtered out
eileenmcnaughton
added a commit
to eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor
that referenced
this pull request
Jan 10, 2021
Hopefully thephpleague/omnipay-sagepay#158 will be merged but for now SagePay assumes that an empty card should be filtered out
|
If you want to merge from master into this branch, the tests should now pass. |
Wiping out the whole array is pretty extreme. Only do it if the card array actually has meaningful values. The code that calls this might be trying to support multiple processors so don't assume it 'knows' not to pass an empty card if the processor is sagepay thephpleague#157 (comment)
eileenmcnaughton
force-pushed
the
card
branch
from
d92bfdc to
5dc3792
Compare
|
done & travis is trying again! |
|
And it's green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wiping out the whole array is pretty extreme. Only do it if the card array actually has
meaningful values. The code that calls this might be trying to support multiple
processors so don't assume it 'knows' not to pass an empty card if the processor is sagepay
#157 (comment)