Several changes, see commit details. #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes
=======
1. In function do_create() change 'a' open mode to 'wb', as 'a' doesn't support unbuffered operation, and "ab" doesn't allow file shrink, only enlarge.
2. Do not create remote file in dry-run mode ('--createdest' option).
3. Server return negative size if remote file doesn't exists. Worker check received value and show error message if it is negative.
4. Send file name and blocksize with separate print(), as filename could contain spaces, so split with not work correct way.
5. Enquote path.
6. Change default ciphering to 'aes128-ctr'. Probably we can just drop that option flag, if cipher is not specified.
7. Change '--compress' option to '--nocompress', as there was no way to switch compression off, which cause significant speed degradation on local network.
|
Could we get this committed? All these changes are sane. |
guppy
added a commit
to guppy/blocksync
that referenced
this pull request
Jul 23, 2023
…heraser#22) and merged in the pieces that don't conflict with my own pull support. I didn't use their wrap function and instead am using shlex.quote.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In function do_create() change 'a' open mode to 'wb', as 'a' doesn't support unbuffered operation, and "ab" doesn't allow file shrink, only enlarge.
Do not create remote file in dry-run mode ('--createdest' option).
Server return negative size if remote file doesn't exists. Worker check received value and show error message if it is negative.
Send file name and blocksize with separate print(), as filename could contain spaces, so split with not work correct way.
Enquote path.
Change default ciphering to 'aes128-ctr'. Probably we can just drop that option flag, if cipher is not specified.
Change '--compress' option to '--nocompress', as there was no way to switch compression off, which cause significant speed degradation on local network.